Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Support testType field as input for bulk-upload #1531

Merged
merged 2 commits into from
Jan 7, 2021

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Jan 7, 2021

Proposed Changes

  • Currently TestType is hard-coded to "confirmed"
  • Allows an optional field to provide another value, remains "confirmed" if omitted

Release Note

Support testType field as input for bulk-upload

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Jan 7, 2021
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit a0ee8fe into google:main Jan 7, 2021
@whaught whaught deleted the testtypecsv branch January 8, 2021 18:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants